Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: magento2 requires mariadb 10.6, for #5919 #5922

Merged
merged 1 commit into from Mar 4, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Mar 1, 2024

The Issue

@stasadev discovered that Magento2 refuses to run with updated MariaDB 10.11 (now default).

How This PR Solves The Issue

Use config override action to use MariaDB 10.6 per https://experienceleague.adobe.com/docs/commerce-operations/installation-guide/system-requirements.html

Manual Testing Instructions

Run through the quickstart using this version.

It should not even require the use of --database=mariadb:10.6 - that should happen by default, but it's reasonable to make it explicit in the quickstart.

Automated Testing Overview

Nothing new.

@github-actions github-actions bot added the bugfix label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

@rfay rfay marked this pull request as ready for review March 3, 2024 18:25
@rfay rfay requested review from a team as code owners March 3, 2024 18:25
@rfay rfay requested a review from stasadev March 3, 2024 18:25
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tested and confirmed that the database is not overwritten on the secondary:

ddev config --project-type=magento2

@rfay rfay merged commit e294282 into ddev:master Mar 4, 2024
26 checks passed
@rfay rfay deleted the 20240301_magento2_requirements branch March 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants