fix: don't call app.WriteConfig twice #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
|
This could also be done with the opposite logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
@ajibarra points out in
that the PostConfigAction is being called twice. It's being called twice because when
ddev configis called with args, the WriteConfig() happens both inside handleMainConfigArgs() and also in the parent handleConfigRun. It should only be called once.How This PR Solves The Issue
ddev configis called without args, we do the WriteConfig() in its contextManual Testing Instructions
I think it requires debugger or adding a print statement, but just add a print statement to a PostConfigAction or to WriteConfig.
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes