New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update faq with new questions, fix menus #5924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download the artifacts for this pull request:
See Testing a PR |
rpkoller
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments and thoughts. Overall that looks great!
Co-authored-by: Ralf Koller <1665422+rpkoller@users.noreply.github.com>
stasadev
requested changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Noticed FAQs that people ask... about code and DDEV, about where the databases live.
How This PR Solves The Issue
make mkdocs-serve
- delete the container on exitManual Testing Instructions
Built docs at https://ddev--5924.org.readthedocs.build/en/5924/users/usage/faq/
Notes
For the mkdocs-not-installed case
make mkdocs-serve
provides a docker-based mkdocs setup thanks to @tyler36The polinux/mkdocs docker image has moved along, and now has arm64 version (not pushed properly), but the current image does not seem to work right on either arm64 or amd64.
I experimented with this, though, to handle arm64, but neither the amd64 nor arm64 images worked right with 1.5.2, so I gave up: