docs: use stable URL for 404 [skip ci] #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
approved these changes
Mar 4, 2024
| @@ -1,7 +1,7 @@ | |||
| # yaml-language-server: $schema=https://squidfunk.github.io/mkdocs-material/schema.json | |||
| site_name: DDEV Docs | |||
| # todo: Make sure to set this to the correct one; otherwise it breaks 404 page | |||
| site_url: https://ddev.readthedocs.io/en/latest/ | |||
| site_url: https://ddev.readthedocs.io/en/stable/ | |||
There was a problem hiding this comment.
Pretty weird if site_url is only for the 404...
There was a problem hiding this comment.
I wondered why we ever need site_url, and found this:
People still complain about it because it hasn't been fixed.
rfay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I noticed that 404 links always point to the latest docs.
How This PR Solves The Issue
Uses stable URL.
I was concerned about
# todo: Make sure to set this to the correct one; otherwise it breaks 404 pagefor thesite_url, so I tested this on my own fork before making this change.Manual Testing Instructions
Current stable: https://ddev.readthedocs.io/en/stable/404 and click any link, see the latest docs.
Current latest: https://ddev.readthedocs.io/en/latest/404 and click any link, see the latest docs.
Latest after merge: https://ddev.readthedocs.io/en/latest/404 (Hard reload the page) and click any link, see the stable docs.
Stable after merge: remains the same.
This change will not fix 404 for stable until the next stable release is out.
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes