fix: rsync example should create db.sql.gz [skip ci] #6022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
It was pointed out that if the rsync provider brings down a file as a name other than db.sql.gz, the database gets created with the filename.
This is by design,
ddev/pkg/ddevapp/provider.go
Lines 364 to 374 in 834a772
But not useful when the rsync example doesn't explicitly control it.
How This PR Solves The Issue
Change the rsync example to explicitly name the dump file as db.sql.gz
I checked the other examples and integrations and don't find any other example of this ambiguity.
Manual Testing Instructions
Try out this
.ddev/providers/rsync.yaml
:Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes