fix: revert removal of Colima host.docker.internal setting

[rfay]

The Issue

We're having a bit of trouble with NFS in colima/lima tb-macos-arm64-5/6/7, I'm not sure why. But we don't need to be testing NFS on macOS anyway, certainly not on orbstack/lima/colima.

• fix: Revert setting 192.168.5.2 for host.docker.internal on colima, fixes #5537 #5994

Lima provides 192.168.5.2 as host.docker.internal, but colima does not seem to have it any more. I assume colima lost it in a recent Lima upgrade.

This probably means that Xdebug is not working on colima since #5994 , but I don't know why it wouldn't have been caught by automated tests.

How This PR Solves The Issue

Revert #5994 to put explicit host.docker.internal back in there again

Manual Testing Instructions

ddev debug nfsmount using colima

[rfay]

I'm probably chasing the wrong problem here, have to look closer.

Details: error=failed to StartContainer: Error response from daemon: error while mounting volume '/var/lib/docker/volumes/testnfsmount/_data': error resolving passed in network volume address: lookup host.docker.internal on 127.0.0.53:53: no such host

https://buildkite.com/ddev/macos-colima-vz/builds/380#018e86b2-655e-4ed5-b24e-5bf8be98d32c

[stasadev]

Can it be related to this change?

• fix: Revert setting 192.168.5.2 for host.docker.internal on colima, fixes #5537 #5994

[rfay]

Yes, that's what it is. I tested and colima is not resolving host.docker.internal any more even though lima is.

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR.

• Test on Gitpod.
• Test on GitHub Codespaces.

[stasadev]

Yes, that's what it is. I tested and colima is not resolving host.docker.internal any more even though lima is.

Is this just a partial revert for NFS or is the Colima check needed again in GetHostDockerInternalIP() ?

[rfay]

Both, I messed up the reversion

[rfay]

Here's the reason we didn't catch this in automated tests

ddev/pkg/ddevapp/ddevapp_test.go

Lines 905 to 911 in 9d73fe5

	func TestDdevXdebugEnabled(t *testing.T) {
	if (dockerutil.IsColima() || dockerutil.IsLima()) && os.Getenv("DDEV_TEST_COLIMA_ANYWAY") != "true" {
	t.Skip("Skipping on Lima/Colima because this test doesn't work although manual testing works")
	}
	if nodeps.IsWSL2() && dockerutil.IsDockerDesktop() {
	t.Skip("Skipping on WSL2/Docker Desktop because this test doesn't work although manual testing works")
	}

[rfay]

Oh I see, we're running the check using brew-installed DDEV v1.23.0-alpha1, which has this bug.