Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Keep hub.docker.com repositories updated, fixes #5847 [skip ci] #6032

Merged
merged 32 commits into from Apr 3, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Mar 29, 2024

The Issue

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay
Copy link
Member Author

rfay commented Mar 30, 2024

Still working on getting goreleaser workflow to work, ongoing conversation in their discord, https://discord.com/channels/890434333251362866/1223342596231925852/1223342596231925852

@rfay rfay force-pushed the 20240329_dockerhub_readme branch from 07cc4c2 to ba332f4 Compare April 2, 2024 03:35
@rfay
Copy link
Member Author

rfay commented Apr 2, 2024

This is complete, and all the template READMEs and hub.docker.com entries have now been updated.

The one thing that remains is we need to switch goreleaser from "nightly" when the next release comes out; he predicts it's soon.

@rfay rfay force-pushed the 20240329_dockerhub_readme branch from 2de2234 to 313aa61 Compare April 2, 2024 15:25
@rfay rfay requested a review from stasadev April 2, 2024 21:12
@rfay rfay force-pushed the 20240329_dockerhub_readme branch from 313aa61 to ee11366 Compare April 3, 2024 03:28
@rfay rfay marked this pull request as ready for review April 3, 2024 03:29
@rfay rfay requested review from a team as code owners April 3, 2024 03:29
@rfay
Copy link
Member Author

rfay commented Apr 3, 2024

Goreleaser v1.25.0 was released so now we can use this version that has this capability without being on "nightly"

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I only have a few suggestions for some docker run commands.

containers/ddev-dbserver/README.md Outdated Show resolved Hide resolved
containers/ddev-php-base/README.md Outdated Show resolved Hide resolved
containers/ddev-webserver/README.md Outdated Show resolved Hide resolved
containers/image_readme_template.md Outdated Show resolved Hide resolved
containers/test-ssh-server/README.md Outdated Show resolved Hide resolved
@stasadev suggestions [skip ci]

Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
@rfay rfay merged commit 1be2555 into ddev:master Apr 3, 2024
4 checks passed
@rfay rfay deleted the 20240329_dockerhub_readme branch April 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants