Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ddev debug configyaml shouldn't double-report upload_dirs, fixes #6036 #6037

Merged
merged 1 commit into from Apr 2, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Mar 30, 2024

The Issue

ddev debug configyaml was showing this (double-report):

upload_dirs: [.ddev/tmp .ddev/tmp]

when a .ddev/config.junk.yaml had:

upload_dirs:
    - .ddev/tmp

How This PR Solves The Issue

Load a clean, fresh "app" before loading additional configs

Affects only ddev debug configyaml

Manual Testing Instructions

Use the config above and ddev debug configyaml, should report only one upload_dirs

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay changed the title fix: ddev debug configyaml shouldn't double-report upload_dirs fix: ddev debug configyaml shouldn't double-report upload_dirs, fixes #6036 Mar 30, 2024
@rpkoller
Copy link
Collaborator

I've quickly tested the arm artifact for macOS. applying the same steps outlined in https://gist.github.com/rpkoller/8fce5577f97af9b5bb788a34a5c74cdb#file-1-23-0-drupal-txt i can confirm i am getting a single entry now:

$> ddev debug configyaml
These config files were loaded for project test: [/Users/rkoller/Sites/test/.ddev/config.yaml /Users/rkoller/Sites/test/.ddev/config.ddev-drupal-core-dev.yaml] 
name: test
type: drupal 
php_version: 8.3 
webserver_type: nginx-fpm 
webimage: ddev/ddev-webserver:20240324_corepack_config 
database: {mariadb 10.11} 
upload_dirs: [.ddev/tmp] 
omit_containers: [db] 
project_tld: ddev.site 
use_dns_when_possible: true 
composer_version: 2 
disable_settings_management: true 
nodejs_version: 20 
corepack_enable: true 
default_container_timeout: 120 ```

@rfay rfay marked this pull request as ready for review April 1, 2024 12:50
@rfay rfay requested a review from a team as a code owner April 1, 2024 12:50
@rfay rfay requested a review from stasadev April 1, 2024 12:50
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, the output is now good 👍

@rfay rfay merged commit 63f9c67 into ddev:master Apr 2, 2024
28 checks passed
@rfay rfay deleted the 20240330_double_upload_dirs branch April 2, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants