fix: make sure CGO_ENABLED is normally off, fixes #6046 #6050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bugfix
dependencies
|
Download the artifacts for this pull request:
See Testing a PR. |
stasadev
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
I checked the artifacts from https://github.com/ddev-test/ddev/releases/tag/v1.22.10-aaa3 and from this PR, both show cgo_enabled 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In DDEV v1.23.0-alpha1, the released binaries were released with CGO_ENABLED=1, which means they can't run everywhere they're intended to run. This includes Ubuntu 20.04
How This PR Solves The Issue
ddev versionso we can check itManual Testing Instructions
You can already test the artifacts built this way from the experimental release https://github.com/ddev-test/ddev/releases/tag/v1.22.10-aaa3 (Do not use this for anything but testing this issue).
ddev versionshould show cgo_enabled=0Automated Testing Overview
We now check in the build pipeline to make sure the CGO_ENABLED version is correct.
Related Issue Link(s)
Release/Deployment Notes