fix: do not explicitly set the backdrop_drupal_compatibility and update_free_access settings, fixes #6090 #6091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
As described in #6090, if these settings are explicitly set in settings.ddev.php, trying to set them in settings.php or settings.local.php never takes.
How This PR Solves The Issue
This PR removes the lines in settings.ddev.php that explicitly set these two settings, which allows the values to be set in settings.php or settings.local.php (which unlike Drupal is provided by default OOTB in Backdrop).
Manual Testing Instructions
settings.php
file or thesettings.local.php
file and set$settings['backdrop_drupal_compatibility'] = FALSE;
.settings_get('backdrop_drupal_compatibility')
(for instance using the devel module anddpm()
or something) -> regardless of how that setting is configured, it is always returned asTRUE
👎🏼settings.php
file or thesettings.local.php
file 👍🏼Automated Testing Overview
N/A
Related Issue Link(s)
Fixes #6090
Release/Deployment Notes
N/A