Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update hardened/prod healthcheck.sh, for #6033 #6126

Merged
merged 1 commit into from
May 13, 2024
Merged

build: update hardened/prod healthcheck.sh, for #6033 #6126

merged 1 commit into from
May 13, 2024

Conversation

stasadev
Copy link
Member

The Issue

I noticed that I forgot to update healthcheck.sh for production.

How This PR Solves The Issue

  1. Copies the supervisorctl changes from fix: shutdown supervisor in healthcheck.sh on fatal error, fixes #5993 #6033
  2. Small reformatting (remove extra spaces, use printf output for variables)

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner April 24, 2024 19:23
@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels Apr 24, 2024
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

See Testing a PR.

rfay
rfay reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The duplication in this area is certainly regrettable.

@rfay rfay added this to the v1.23.1 milestone May 3, 2024
@stasadev stasadev mentioned this pull request May 10, 2024
Merged
@stasadev stasadev force-pushed the 20240424_stasadev_healthcheck branch from ec9b76b to 35f67be Compare May 13, 2024 14:53
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label May 13, 2024
@stasadev stasadev merged commit 0806ba7 into ddev:master May 13, 2024
9 checks passed
@stasadev stasadev deleted the 20240424_stasadev_healthcheck branch May 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay left review comments

Assignees

@stasadev stasadev

Labels
maintenance
Projects
None yet
Milestone
v1.23.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stasadev @rfay