-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update PHPStorm instructions to include COMPOSE_PROJECT_NAME in manual instructions #6226
Conversation
Thanks, I'm surprised that was missing. The numbering looks wrong in the PR, but seems to come out OK when rendered, https://ddev--6226.org.readthedocs.build/en/6226/users/install/phpstorm/#manual-setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It's odd that COMPOSE_PROJECT_NAME is still required, since the project name is set in the .ddev/.ddev-docker-compose-full.yaml.
I wonder if it was removed here when it was introduced into the .ddev-docker-compose-full.yaml
One question @michielgerritsen - AFAIK nobody has been able to get the PHP client setup working in PhpStorm 2024.x. Does that mean you were manually setting up PhpStorm 2023.x? |
Hey @rfay, are you talking about the PHPStorm plugin? My version was too new to install it. I have version 2024.something (1?), and that was not supported. But I needed to run my tests so that's why I followed those steps. |
This was impossible to get working until PhpStorm 2024.2 EAP. But I do confirm that it can work in PhpStorm 2024.2 EAP. See https://discordapp.com/channels/664580571770388500/1239527694371131403/1242893198616039615 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've learned with a project name like PHPInterpreter and it doesn't work
Co-authored-by: Marco Schmidt <48087020+SchmidtWebmedia@users.noreply.github.com>
… manual instructions (ddev#6226) [skip ci] Co-authored-by: Randy Fay <randy@randyfay.com> Co-authored-by: Marco Schmidt <48087020+SchmidtWebmedia@users.noreply.github.com>
The Issue
The PHPStorm instructions are pretty clear, but setting the
COMPOSE_PROJECT_NAME
was missing from the instructions, making it impossible to set up PHPStorm. The screenshot already included this variable.How This PR Solves The Issue
It adds a step in the instructions that explains that you need to set it and what the value should be.
Manual Testing Instructions
Automated Testing Overview
You can't automate this afaik.
Related Issue Link(s)
N/A
Release/Deployment Notes
N/A