-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: standardize apt-get usage, remove blackfire from apt sources, for #6235, for #6078 #6236
build: standardize apt-get usage, remove blackfire from apt sources, for #6235, for #6078 #6236
Conversation
IMO we should remove the /etc/apt/sources.list.d/blackfire.list after the installation in the ddev-webserver Dockerfile, since Blackfire is such low priority and since it so often causes trouble. That can be done here or in a later PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Let's just use apt-get update
and apt-get install
and apt-get upgrade` in all the places, just for consistency. It also prevents the "no consistent api" message or whatever it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks perfect.
8327dd8
to
16ee902
Compare
Download the artifacts for this pull request:
See Testing a PR. |
16ee902
to
00f4fd5
Compare
The Issue
apt-get update
can fail in the user's custom Dockerfiles.I thought we could search for
apt-get update
using a regex and automatically replace it in the resulting Dockerfile, but that seems like overkill because people can write it with different variations, like:apt-get update
apt-get update -y
apt-get update -qq
apt-get update -qq >/dev/null
And the same with
apt
, so it's probably impossible to write a good regex to cover all cases and not break anything.How This PR Solves The Issue
Replaces
apt-get update
with(apt-get update || true)
in the docs.Uses
apt-get
instead ofapt
everywhere.Removes
/etc/apt/sources.list.d/blackfire.list
as we pin the blackfire package to a specific version and don't need it inapt-get update
:Manual Testing Instructions
ddev start
ddev ssh
sudo apt-get update | grep blackfire
should give an empty resultAutomated Testing Overview
Related Issue Link(s)
Release/Deployment Notes