Remove windows warning about running containers as root, fixes #800 #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
|
I think @cweagans will be able to test this more quickly than me. I'm still slow on Windows because I don't spend a lot of time using Parallels except when absolutely necessary. Adding him to the reviewer list. |
|
This is WIP, not ready for testing. |
|
I don't have a functioning Windows install at the moment, but it's on my list for the weekend. I can do it sooner if necessary though. |
rfay
force-pushed
the
20180420_run_windows_as_1000
branch
from
7691782
to
ce614d5
Compare
rfay
changed the title
|
This is ready for review; I went another way, and added a test for writeability of files directory. |
rfay
force-pushed
the
20180420_run_windows_as_1000
branch
3 times, most recently
from
ab14415
to
1bb1e2c
Compare
rfay
force-pushed
the
20180420_run_windows_as_1000
branch
from
1bb1e2c
to
6613afc
Compare
|
Note that the latest push of this has the windows installer, so should be pretty easy to do a runthrough. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #800 - Awkward warning (repeated lots) about Windows containers running as root.
This is not a threat on Docker for Windows, and in fact doesn't seem to work otherwise, so omit the warning for that situation.
Manual Testing Instructions:
Run on windows, verify correct behavior:
It's reasonable to do modest test on another environment too, maybe linux with a UID like 65000.
Note that the latest push of this has the windows installer, so should be pretty easy to do a runthrough.
Automated Testing Overview:
Related Issue Link(s):
OP #800
Release/Deployment notes: