Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ddev logs work against stopped project/container, fixes #719 #823

Merged
merged 2 commits into from
May 4, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented May 3, 2018

The Problem/Issue/Bug:

OP #719: Currently ddev logs only works against running containers, so is useless when trying to debug a stopped container (perhaps stopped for a healthcheck failure). This commonly happens when people add custom config that is broken. But then ddev logs doesn't help them and we have to coach them on using the more arcane docker logs options.

How this PR Solves The Problem:

There was an explicit stanza that forbade getting logs on stopped containers. Remove it.

Manual Testing Instructions:

  • Start a project
  • Stop the project
  • Run ddev logs and ddev logs -s db to see the logs from the project.

Automated Testing Overview:

I didn't add anything.

Related Issue Link(s):

OP #719

Release/Deployment notes:

@rfay rfay changed the title Make ddev logs work against stopped site/container, fixes #719 Make ddev logs work against stopped project/container, fixes #719 May 3, 2018
Copy link
Contributor

@rickmanelius rickmanelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test with v0.17.0 and this PR. I can confirm that it wasn't working before (with v0.17.0 I received a message that the project was stopped), but with the PR I get the same results as when the container is running.

@rfay rfay merged commit e8aa172 into ddev:master May 4, 2018
@rfay rfay deleted the 20180503_logs_while_stopped branch May 4, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants