Make ddev logs work against stopped project/container, fixes #719 #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #719: Currently
ddev logs
only works against running containers, so is useless when trying to debug a stopped container (perhaps stopped for a healthcheck failure). This commonly happens when people add custom config that is broken. But thenddev logs
doesn't help them and we have to coach them on using the more arcane docker logs options.How this PR Solves The Problem:
There was an explicit stanza that forbade getting logs on stopped containers. Remove it.
Manual Testing Instructions:
ddev logs
andddev logs -s db
to see the logs from the project.Automated Testing Overview:
I didn't add anything.
Related Issue Link(s):
OP #719
Release/Deployment notes: