Make ComposeCmd() interactive again, fixes #859 #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerjfco
approved these changes
May 17, 2018
|
Heh. I was mid test and this also worked. :) Preparation
Test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
OP #859: Output from docker-compose command was no longer interactive, so it was impossible to tell what was happening as it pulled images, and it looked like it was hung.
How this PR Solves The Problem:
This PR makes ComposeCmd() exactly what it was before #845 messed it up.
Manual Testing Instructions:
Use
docker rmito remove the nginx-php-fpm-local image. Thenddev start. You should see it pulling the image as it does it.Related Issue Link(s):
OP #859, Regression introduced in #845
Release/Deployment notes: