Bump container versions to planned v0.19.0 for release #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfrench
approved these changes
May 30, 2018
There was a problem hiding this comment.
All containers were pulled successfully and I was able to start, restart, ssh, and interact with multiple sites with ddev with ddev version:
router drud/ddev-router:v0.19.0
commit v0.18.0-26-g85e70b3d
domain ddev.local
cli v0.18.0-26-g85e70b3d
web drud/nginx-php-fpm-local:v0.19.0
db drud/mariadb-local:v0.19.0
dba drud/phpmyadmin:v0.19.0
Approved.
|
Thanks for taking the extra effort for the manual review @andrewfrench ! |
|
I'm having a bit of trouble with the testbots, but it doesn't seem to have anything to do with this PR. So as soon as both are up again, I'll pull this and we'll rely on the master test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Our container code is now part of the main code tree, so during development we used temporary pushed container.
Now, though, we're about to do a release with the code in our containers. But we want to be able to test and reference the new containers (all tagged v0.19.0 on dockerhub) at the time of the tag.
To do that we have to temporarily push v0.19.0 containers, so I've just done that with the current code.
Manual Testing Instructions:
Use it, look at the tests.
Release/Deployment notes:
The 4 containers should be re-pushed at tag time.