-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use apk cache to reduce image size #945
Conversation
Added @rfay to review because I wasn't sure if there was a particular reason for this. |
This looks great to me, thanks. I pushed this to drud/mariadb-local:20180627_mariadb_no_apk_cache - @t3easy if you could please add a commit setting that container in pkg/version/version.go it would be fantastic. Otherwise ask us to do it and tell us you don't mind us pushing into your fork. |
I should note that this seems to reduce the image size by less than 1MB, so might not be as effective as you hoped. https://hub.docker.com/r/drud/mariadb-local/tags/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, there's no reason to be pushing around a cache with the container image. Once @rfay's version.go
request is in, this is good to pull.
Just to confirm @rfay's point about the image size, here's a comparison of this version and the v0.20.0 image:
I'd say the change is still valid either way, especially since I'm seeing |
It's not dramatically but best practice. Regarding
Just rais |
We use temporary tags between releases, when we release ddev v1.0.0 (the next one) we'll retag the latest version of the mariadb-local container to v1.0.0 to match the ddev version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
The Problem/Issue/Bug:
Apk cache remains in image and makes it larger as it must be
How this PR Solves The Problem:
Use apk --no-cache parameter
Manual Testing Instructions:
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes: