Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only complain about config.yaml version on start if necessary, fixes #957 #963

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 2, 2018

The Problem/Issue/Bug:

OP #957 - On update of ddev people were getting plowed under with warnings about every project they had running, and there was no context about with config.yaml needed to be updated.

How this PR Solves The Problem:

  • Only warn on ddev start, not every single place a config is read
  • Add the full path to the warning so people can understand which config.yaml is in play.

Manual Testing Instructions:

See OP #957 - Use ddev list and ddev start

Related Issue Link(s):

OP #957

@rfay rfay self-assigned this Jul 2, 2018
@rfay rfay requested a review from andrewfrench July 2, 2018 18:49
@rfay rfay added this to the v1.0.0 milestone Jul 2, 2018
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ddev list no longer prints out an imposing list of config version warnings, but ddev start will print a warning and specify the full path to the relevant config file.

Moving the version check to app.Start() makes sense to me, approved.

@rfay rfay merged commit 71ae0db into ddev:master Jul 2, 2018
@rfay rfay deleted the 20180702_ddev_list_no_complaint branch July 2, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants