Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Windows 10 Home and Enterprise, update min docker versions, fixes #884, fixes #896 #965

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Update docs for Windows 10 Home and Enterprise, update min docker versions, fixes #884, fixes #896 #965

merged 3 commits into from
Jul 5, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 3, 2018 •
edited

The Problem/Issue/Bug:

  • Docs for Win 10 Home (Docker Toolbox) were incomplete
  • We didn't mention that we now support Windows 10 Enterprise (because Docker for WIndows does)
  • Update minimum versions of docker (18.03) and docker-compose (1.19)

@rfay rfay added this to the v1.0.0 milestone Jul 3, 2018
@rfay rfay self-assigned this Jul 3, 2018
@rfay rfay changed the title Update docs for Windows 10 Home and Enterprise, fixes #884, fixes #896 Update docs for Windows 10 Home and Enterprise, update min docker versions, fixes #884, fixes #896 Jul 3, 2018
andrewfrench
andrewfrench approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition of Windows installation instructions and updating docker/docker-compose version to what we actually need.

@rfay rfay merged commit 3d855f6 into ddev:master Jul 5, 2018
@rfay rfay deleted the 20180603_win_10_enterprise_home_docs branch July 5, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfrench andrewfrench andrewfrench approved these changes

@rickmanelius rickmanelius Awaiting requested review from rickmanelius

Assignees

@rfay rfay

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfay @andrewfrench