Yet another round of battling building and testing containers on Windows #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20180703_fix_windows_containers
branch
from
fc3d9d5
to
d78c1c9
Compare
rfay
force-pushed
the
20180703_fix_windows_containers
branch
from
0618b45
to
4aa3299
Compare
Does this actually work?
rfay
force-pushed
the
20180703_fix_windows_containers
branch
from
cc89924
to
db7e51c
Compare
|
Much pain, much learning. I think this is ready for a quick review. Mostly I learned about agent setup, and may still have some work to do on that, maybe an agent qualifier script that makes sure git works right and all the right tools are installed? |
rfay
force-pushed
the
20180703_fix_windows_containers
branch
from
fb3645e
to
4c60ebe
Compare
andrewfrench
reviewed
Jul 9, 2018
.buildkite/test_containers.sh
Outdated
| @@ -7,6 +7,12 @@ set -o pipefail | |||
| set -o nounset | |||
| set -x | |||
|
|
|||
| echo "--- Cleanup docker" | |||
| echo "Warning: deleting all docker containers and deleting ~/.ddev/Test*" | |||
There was a problem hiding this comment.
I don't think ~/.ddev/Test* gets deleted, if we're still expecting that to happen.
There was a problem hiding this comment.
Great point - It's a copy-from-original-script problem. This script doesn't ever create anything in ~/.ddev, I'll fix that.
|
I'm probably good with this now, my energy may have run its course again :) |
andrewfrench
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
We seem to never be able to build and test our containers on WIndows and elsewhere.
Trying again.
How this PR Solves The Problem:
Script and docs (mostly) updates, and agent debugging
Manual Testing Instructions:
Build should run reliably on each testbot, especially windows testbots.