Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about composer on Windows #970

Merged
merged 2 commits into from
Jul 5, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 4, 2018

The Problem/Issue/Bug:

We advocated using composer on the host in our quickstart, because that's fairly easy to do on macOS and Linux.

However, users on Windows will never be able to succeed with that, and have to be much more sophisticated.

How this PR Solves The Problem:

Point them to the Stack Overflow article about ddev with composer.

@rfay rfay added this to the v1.0.0 milestone Jul 4, 2018
@rfay rfay self-assigned this Jul 4, 2018
@rfay rfay force-pushed the 20180704_composer_quickstart branch from 3112e35 to 549d12b Compare July 4, 2018 21:52
Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting nit, otherwise approved.

@@ -127,6 +128,7 @@ cd example-typo3-site
If necessary, run build steps that you may require, like `composer install` in the correct directory.

**Composer Setup Example**
*Do not use this technique with Windows, as composer on an NTFS filesystem can result in major problems with NTFS symlinks that can't be read in the Linux web container. Instead, use the [community-provided hints on Stack Overflow](https://stackoverflow.com/questions/49660082/how-can-i-run-composer-with-ddev)*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe lines 131 and 87 need another newline to put this warning in its own Markdown paragraph.

@rfay rfay force-pushed the 20180704_composer_quickstart branch from 549d12b to 392bd06 Compare July 5, 2018 22:39
@rfay rfay merged commit e7cc6eb into ddev:master Jul 5, 2018
@rfay rfay deleted the 20180704_composer_quickstart branch July 5, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants