Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mariadb-local test to work on linux without making un-deletable files #975

Merged
merged 6 commits into from
Jul 6, 2018

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 5, 2018

The Problem/Issue/Bug:

Nightly build is breaking due to changes in how we test/generate the mysql starter db. See https://circleci.com/gh/drud/ddev/3052?utm_campaign=build-failed&utm_medium=email&utm_source=notification

How this PR Solves The Problem:

Try to make the output not violate fs permissions.

Manual Testing Instructions:

Run the nightly build against this PR.

@rfay rfay added this to the v1.0.0 milestone Jul 5, 2018
@rfay rfay self-assigned this Jul 5, 2018
@rfay rfay requested a review from andrewfrench July 5, 2018 17:53
@rfay rfay force-pushed the 20180705_nightly_build_failure_maria_test branch from 70f3238 to b854d9f Compare July 5, 2018 22:53
@rfay
Copy link
Member Author

rfay commented Jul 6, 2018

Looks to me like this will solve the problem @andrewfrench , and it has a little bit to say about macOS testing too, the buildkite builds were using /usr/local...buildkite as $HOME, and that isn't configured for mounting onto docker on default macOS docker-for-windows.

Copy link
Contributor

@andrewfrench andrewfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after a casual scan/sanity check

@rfay rfay merged commit fae2e47 into ddev:master Jul 6, 2018
@rfay rfay deleted the 20180705_nightly_build_failure_maria_test branch July 6, 2018 22:06
andrewfrench pushed a commit to andrewfrench/ddev that referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants