Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v2 of keepalive-workflow #27

Closed
rfay opened this issue Mar 11, 2024 · 3 comments · Fixed by #28
Closed

Use v2 of keepalive-workflow #27

rfay opened this issue Mar 11, 2024 · 3 comments · Fixed by #28

Comments

@rfay
Copy link
Member

rfay commented Mar 11, 2024

keepalive-workflow@v2 is now available, which does not require the dummy commits every 2 months. Consider using it.

https://github.com/gautamkrishnar/keepalive-workflow/releases/tag/2.0.0

@rfay
Copy link
Member Author

rfay commented Mar 12, 2024

I guess this also requires a change to the permission statement, so perhaps we need a new major version of this action to support it?

@julienloizelet
Copy link
Collaborator

I guess this also requires a change to the permission statement, so perhaps we need a new major version of this action to support it?

Yes, from what I understand in the "migrating from v1 to v2" section, the user of our github action will have to modify the permission part accordingly in order to have a functional keepalive step.

I consider this is a breaking change and will create a "v2" major tag for the release.

@rfay
Copy link
Member Author

rfay commented Mar 14, 2024

I guess since users will have to change to @v2 and such, we'll gradually switch over and we'll have experience with it in case it doesn't work as advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants