Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update Release 2.0 to say explicitly what needs to change #27

Closed
rfay opened this issue Mar 11, 2024 · 6 comments
Closed

Please update Release 2.0 to say explicitly what needs to change #27

rfay opened this issue Mar 11, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@rfay
Copy link
Contributor

rfay commented Mar 11, 2024

in https://github.com/gautamkrishnar/keepalive-workflow/releases/tag/2.0.0 you say

People who are using v1 and master tags of this workflow will continue using the dummy commit method since the newly added API-based method requires explicit permission for the API Keys for it to function.

but you don't mention what permission has to be changed.

It looks to me like you're saying that

permissions:
  contents: write

must be changed to:

permissions:
  actions: write

Could you please just show the simple change of an action in the release notes (and probably in the README?)

Thanks for all the work on this!

@gautamkrishnar
Copy link
Owner

@rfay thats a good suggestion. Will add more info on the readme. Most people will rather continue using version 1 that's the main reason why I never added that.

@rfay
Copy link
Contributor Author

rfay commented Mar 11, 2024

I don't agree! It's a great new feature, and those commits were a real pain, completely obscuring the history of the repo.

The only thing I don't know is... how do I know it's working? I put a TODO to remember to check one of the repos I changed in 2 months :)

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Mar 11, 2024

Yea, I also agree that commits are a real pain.

The new API based method. As far as I know #1 (comment) suggested that it's working fine. I also tested using some pre-dated commits and it worked just fine.

@gautamkrishnar gautamkrishnar added the enhancement New feature or request label Mar 11, 2024
@rfay
Copy link
Contributor Author

rfay commented Mar 11, 2024

I don't doubt it... just wish there was some output or something that gave me confidence. We'll change https://github.com/ddev/github-action-add-on-test to use v2 and it will affect many, many repositories, and if their tests stop running we may not notice for ages.

Thanks!

gautamkrishnar added a commit that referenced this issue Mar 11, 2024
gautamkrishnar added a commit that referenced this issue Mar 11, 2024
@gautamkrishnar
Copy link
Owner

Updated this in the changelog as well, Thanks again for the suggestion @rfay

@gautamkrishnar
Copy link
Owner

I don't doubt it... just wish there was some output or something that gave me confidence.

@rfay it shows output on the test logs, after 50 days of inactivity it will start calling the API.

If you wanna see it calling the API immediately, simply set the time_elapsed option to 0. Other than that waiting for the next 50 days is the only option for active repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants