Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

488: Restructure static files #520

Merged
merged 1 commit into from
May 29, 2019
Merged

Conversation

afuetterer
Copy link
Contributor

Proposed changes

This PR introduces the following changes to the code base.

  • remove static/ from version control
  • remove ddionrails-visualization from dependencies
  • add d3.js to dependencies
  • move static assets from static/src/ to assets/ directory
  • update webpack.config.js
  • build multiple webpack bundles

Related issues:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Pytest passes locally with my changes

Further comments

@hansendx: It works on my machine. But I doubt this set up is conforms to any best practices of web development.

It feels wrong to do stuff like this:

import { basketButton } from "./basket_button.js";
window.basketButton = basketButton;

But I could not access lots of functions without "glueing" them to window.

- remove static/ from version control
- remove ddionrails-visualization from dependencies
- add d3.js to dependencies
- move static assets from static/src/ to assets/ directory
- update webpack.config.js
- build multiple webpack bundles
@afuetterer afuetterer requested a review from hansendx May 29, 2019 13:37
@afuetterer afuetterer added Type: Refactoring Topic: UI Issues about UI, Frontend labels May 29, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #520 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #520   +/-   ##
=======================================
  Coverage     62.2%   62.2%           
=======================================
  Files           70      70           
  Lines         3646    3646           
  Branches       366     366           
=======================================
  Hits          2268    2268           
  Misses        1336    1336           
  Partials        42      42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d660a3a...30bfc7a. Read the comment docs.

@hansendx hansendx merged commit 9643aab into develop May 29, 2019
@hansendx hansendx deleted the refactor/488-static-files branch June 3, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: UI Issues about UI, Frontend Type: Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants