Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronising envelopes doesn't work #1318

Closed
12pm opened this issue Oct 2, 2018 · 13 comments
Closed

Synchronising envelopes doesn't work #1318

12pm opened this issue Oct 2, 2018 · 13 comments
Labels
client Related to the client-side. enhancement Provides an enhancement to the game.

Comments

@12pm
Copy link
Contributor

12pm commented Oct 2, 2018

Animations with checked "Synchronised" option don't reset on going through start.

@heinrich5991
Copy link
Member

This is expected. They're synchronized between all clients. It was some preparing work for the teeuniverse stuff, so it could be reverted — but I think we should rather render it the same way as it is rendered in vanilla maps.

@12pm
Copy link
Contributor Author

12pm commented Oct 3, 2018

Don't you have synchronization between all clients with the option turned off already? Since teeuniverse is not a thing anymore, it would be nice to restore the old behavior.

@heinrich5991
Copy link
Member

Don't you have synchronization between all clients with the option turned off already?

No. If you have the option turned off, the animation is relative to the join time.

@12pm
Copy link
Contributor Author

12pm commented Oct 4, 2018

#1214 Maybe default sync it to server time and make it optional to sync it to race time? At least for DDRace maps, reseting it on joining doesn't have any advantage over reseting it on server start really.

@heinrich5991
Copy link
Member

Mh. It's probably hard to properly synchronize with race time: What happens before you start the race? What happens in the moment you start the race? I'd guess the animation flickered before we separated race time from game time, which doesn't sound particularly polished.

@heinrich5991
Copy link
Member

Maybe it could wait in an unanimated state until the race starts.

@fokkonaut
Copy link
Contributor

dont sync on race time, sync it on server time so every client will always see the same animation on the selected quad.

@def- def- added enhancement Provides an enhancement to the game. client Related to the client-side. labels Mar 19, 2019
@Learath2
Copy link
Member

Learath2 commented Jul 1, 2019

Is this still wanted?

@fokkonaut
Copy link
Contributor

ofc

@12pm
Copy link
Contributor Author

12pm commented Jul 1, 2019

yes

@heinrich5991
Copy link
Member

dont sync on race time, sync it on server time so every client will always see the same animation on the selected quad.

I believe this is the case today if you select "synchronized".

Is this still wanted?

I think synchronizing on race time is a bad idea because of the reason outlined above.

@Chairn
Copy link
Contributor

Chairn commented Aug 8, 2022

Relevant PR: #602

One way could be to synchronize every game elements to race time which would also allow 100% reproducible run.

@heinrich5991
Copy link
Member

Not synchronizing envelopes to race time but to server time is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to the client-side. enhancement Provides an enhancement to the game.
Projects
None yet
Development

No branches or pull requests

6 participants