Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ar: "pagination" entry #577

Closed
ddnexus opened this issue Jan 10, 2024 · 9 comments
Closed

Add ar: "pagination" entry #577

ddnexus opened this issue Jan 10, 2024 · 9 comments
Milestone

Comments

@ddnexus
Copy link
Owner

ddnexus commented Jan 10, 2024

No description provided.

@ddnexus ddnexus added this to the ARIA milestone Jan 10, 2024
@ddnexus ddnexus changed the title Add ar: "pagination" entry (arabic) Add ar: "pagination" entry Jan 10, 2024
@benkoshy
Copy link
Collaborator

benkoshy commented Jan 21, 2024

@m-abdurrehman

Thank you again for your contribution to the arabic locale.

We are in the process to improve the labelling of pagy helpers in order to comply with the ARIA standards.

We are seeking your advice with the pluralized translation of the "Page", "Pages" label, for each required plural listed below:

 page_label:
      zero: "?"
      one: "?"
      two: "?"
      few: "?"
      many: "?"
      other: "?"

Please, feel free to post a comment with your translations. You don't need to create a formal PR (if you don't want to): we can manage it crediting you.

Thank you in advance for your help!

@mohammed-bageri
Copy link

page_label:
zero: "لا يوجد صفحات"
one: "صفحة"
two: "صفحتين"
few: "صفحات"
many: "صفحات"

@ddnexus
Copy link
Owner Author

ddnexus commented Jun 27, 2024

Thank you @mohammed-bageri !!!

@mohammed-bageri
Copy link

mohammed-bageri commented Jun 27, 2024

@ddnexus you are welcome. pagy is so great. and it will be even better with multiple languages.

@AliOsm
Copy link
Contributor

AliOsm commented Jul 3, 2024

After upgrading to a pagy version using this change, I got the following error:

ActionView::Template::Error (translation data {:zero=>"لا يوجد صفحات", :one=>"صفحة", :two=>"صفحتين", :few=>"صفحات", :many=>"صفحات"} can not be used with :count => 200. key 'other' is missing.):

I think other key should be added.

cc @ddnexus @mohammed-bageri

@mohammed-bageri
Copy link

it's the same as many in arabic

@mohammed-bageri
Copy link

page_label:
zero: "لا يوجد صفحات"
one: "صفحة"
two: "صفحتين"
few: "صفحات"
many: "صفحات"
other: "صفحات"

@ddnexus
Copy link
Owner Author

ddnexus commented Jul 3, 2024

Oops. It would have worked if we omitted the many, leaving the other, but not the other way around.

@ddnexus ddnexus reopened this Jul 3, 2024
@AliOsm
Copy link
Contributor

AliOsm commented Jul 3, 2024

Oops. It would have worked if we omitted the many, leaving the other, but not the other way around.

Release nooooow 😂

@ddnexus ddnexus closed this as completed in 719d2a3 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants