Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes boundary character escaping in regex in js trim function #239

Merged
merged 1 commit into from May 1, 2020

Conversation

artplan1
Copy link
Contributor

@artplan1 artplan1 commented Apr 30, 2020

Fixes #238
adding additional backslash https://www.w3schools.com/Jsref/jsref_regexp_begin.asp fixes it

is it possible to add js tests?

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #239   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          530       530           
=========================================
  Hits           530       530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c4f39...b13ecf0. Read the comment docs.

@ddnexus
Copy link
Owner

ddnexus commented Apr 30, 2020

Thank you for this! I missed that the regexp was in a string!

About tests... I have a WIP setup for js tests using sinatra/selenium/capybara. It works but it's still missing tests, and I have no time to complete that.

If you want to help we could coordinate.

@artplan1
Copy link
Contributor Author

If you want to help we could coordinate.

sure, maybe you can give me link to that branch and I can check what can I do

@ddnexus
Copy link
Owner

ddnexus commented Apr 30, 2020

Thank you. I will cleanup the branch and push it tomorrow.

@ddnexus ddnexus changed the base branch from master to dev May 1, 2020 11:44
@ddnexus ddnexus merged commit d7a9f7a into ddnexus:dev May 1, 2020
@ddnexus
Copy link
Owner

ddnexus commented May 1, 2020

@artplan1 pushed https://github.com/ddnexus/pagy/tree/acceptance-tests . Please, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim doesn't work with pagy_nav_js
2 participants