Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove Bundler 1.x workaround #296

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

olleolleolle
Copy link
Contributor

The "github" source now has that form, already.

This PR only serves to simplify that Gemfile.

The "github" source now has that form, already.
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #296 (38b6d60) into master (45e8769) will not change coverage.
The diff coverage is n/a.

❗ Current head 38b6d60 differs from pull request most recent head 243139f. Consider uploading reports for the commit 243139f to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #296   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         1868      1868           
=========================================
  Hits          1868      1868           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e8769...243139f. Read the comment docs.

@ddnexus ddnexus merged commit e5ee4e7 into ddnexus:master Apr 14, 2021
@ddnexus
Copy link
Owner

ddnexus commented Apr 14, 2021

Thank you!

This PR was failing in travis.ci. Then, since it's an intermittent problem happening since a few days, I just re-built it and it worked this time.

I think it's related to the warning of codecov circular require, which is happening because simplecov requires it on its own with docile when on travis and on ruby 3.0, and there is a require in the .simplecov file too. I will fix that next ;).

Thanks

@olleolleolle olleolleolle deleted the patch-1 branch April 14, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants