Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple values per parameter are not supported #26

Closed
paulrutter opened this issue Oct 16, 2015 · 2 comments
Closed

Multiple values per parameter are not supported #26

paulrutter opened this issue Oct 16, 2015 · 2 comments

Comments

@paulrutter
Copy link
Contributor

When using multiple values per parameter, the oAuth sign is not correct.
The codebase does not take multiples into account, and treats it as 1 String.

oauth.authorize({ 
  formKey: ["formvalue1", "formvalue2"] 
});

I have debugged (and fixed) this, and will create a pull request for it.
paulrutter added a commit to paulrutter/oauth-1.0a that referenced this issue Oct 16, 2015
@paulrutter
Add support for multiple values
0c608b6 
See ddo#26 for the accompanying issue.
It would be nice if this pull request could be merged asap, so i don't have to overrule these functions manually in my codebase.

Thanks in advance.
@paulrutter paulrutter mentioned this issue Oct 16, 2015
Closed
paulrutter added a commit to paulrutter/oauth-1.0a that referenced this issue Oct 27, 2015
@paulrutter
https://github.com/ddo/oauth-1.0a/issues/26
2de8827 
- Fix for multiples values in data object
- Added test
@paulrutter
Copy link
Contributor Author

See #28

@ddo
Copy link
Owner

ddo commented Oct 27, 2015

ty very much, i will push to npm asap today

@ddo ddo closed this as completed Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddo @paulrutter