Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more reference changes #29

Closed
wants to merge 4 commits into from
Closed

more reference changes #29

wants to merge 4 commits into from

Conversation

Hecatron
Copy link
Contributor

  1. I've added a reference to CppSharp.Runtime to QtSerialPort lib
  2. I've also marked QtGUI and QtSerialPort as friend assemblies in relation to QtCore
    This way they can access the stuff marked as internal within QtCore without errors
    https://msdn.microsoft.com/en-us/library/0tke9fxk.aspx
  3. added a reference to QtCore in Setup

With a couple of minor manual changes it's now possible to get QtSerialPort to build within Visual Studio
I haven't yet tried the same trick with QtGui, and there's no telling if it will actually run / do stuff
but we seem to be fairly close to be able to build without errors at least which is a good sign

The manual changes include

  1. changing QSerialPort so that it inherits from QIODevice
    "public unsafe partial class QSerialPort : QIODevice, IDisposable"
    there seems to be a problem with CppSharp picking up on inheritance
  2. implement 2 missing members ReadData / WriteData

@ddobrev
Copy link
Owner

ddobrev commented Mar 14, 2015

Hello @grbd . I am grateful for your work so far but I am afraid I cannot take this pull. You added a dependency from QtSerialPort to QtCore manually, while dependencies can, and should, be added automatically. A fellow named Pyry completed a large part of the work on dependencies but three more pieces are still missing - points 1, 2 and 3 from #8 (comment) . The same goes for InternalsVisibleTo which are closely related to the dependencies - the info needed for dependencies can and should be used to generate InternalsVisibleTo attributes automatically. I also think that ReadData / WriteData were ignored because of dependencies. Once the latter is complete, these members will appear on their own.
In general, please note that I don't want the project files and code of the wrappers in the repository at all. I merged a pull by Pyry putting them in and I only did that because I was extremely busy then in order to discuss it with him properly while on the other hand I didn't want to stop his work because he had contributed a few important pieces. I am sorry if the presence of these files has lead you in the wrong direction. However, I am willing to leave them in for the time being if you or other contributors find it easier to work this way.

@Hecatron
Copy link
Contributor Author

no problem I understand what your saying
thanks for the info, I'll try and have a look at the stuff by Pyry

…e generated output for non QtCore modules"

This reverts commit e3bca82.
…lPort as friend assemblies"

This reverts commit 3f8bb2a.
@Hecatron
Copy link
Contributor Author

Hecatron commented Oct 4, 2015

Closing as out of date

@Hecatron Hecatron closed this Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants