Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored process launching to always use spawn, i.e.
Process.spawn
for Ruby 1.9 andPOSIX::Spawn.spawn
for Ruby 1.8 and JRuby.Furthermore I've re-added support for
PTY
to address the missing output issue. Ruby doesn't bufferstdout
when atty
is present.stdin
on the other hand is closed to keep processes from expecting user input.I've also removed
foreman-runner
since the tests are passing without it.Let me know what you think.