Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command prefix. #410

Closed
wants to merge 3 commits into from
Closed

Conversation

adamjt
Copy link

@adamjt adamjt commented Nov 5, 2013

We use foreman to generate upstart scripts for use on production with Docker. To achieve this we specify a prefix like:

docker run -v /data/tmp:/tmp -e RAILS_ENV=$RAILS_ENV -e PORT=$PORT -e CUSTOM_LOGFILE=STDOUT

That way we can still use foreman for local dev.

@bfulton
Copy link
Contributor

bfulton commented Nov 11, 2013

Check out Dockly @ddollar, you can get a sense of how we're using prefixes.

@colszowka
Copy link

👍

@ddollar
Copy link
Owner

ddollar commented Apr 22, 2014

In this case I believe you should create a new exporter that supports the docker export rather than adding an additional option to all exports.

@ddollar ddollar closed this Apr 22, 2014
@bfulton
Copy link
Contributor

bfulton commented Apr 23, 2014

@ddollar, thanks for the feedback and we're happy to open a docker+upstart pull introducing a specialized exporter. The reason this seemed cross-cutting to us is that people are free to use whatever OS and init regime they want inside a container, so this seemed like the best way to leverage existing foreman support for export targets.

Let us know if this changes your opinion. Again, we're happy to take a different approach, just want to figure out the best way to avoid duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants