Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table_to_parquet() can now convert files with uppercase extensions #54

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

ddotta
Copy link
Owner

@ddotta ddotta commented Feb 29, 2024

No description provided.

@ddotta ddotta requested a review from nbc February 29, 2024 15:12
@ddotta
Copy link
Owner Author

ddotta commented Feb 29, 2024

@nbc a quick PR because some users urgently need to convert SAS files with extensions written in uppercase.
As a result, I went for the simplest and most urgent solution, due to lack of time.
Are you ok?

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (f17e000) to head (1580353).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   99.72%   97.52%   -2.21%     
==========================================
  Files          16       16              
  Lines         363      363              
==========================================
- Hits          362      354       -8     
- Misses          1        9       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddotta ddotta merged commit 23329b7 into main Feb 29, 2024
5 of 6 checks passed
@ddotta ddotta deleted the issue-50 branch February 29, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant