-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0 to main branch #1778
Merged
v2.0 to main branch #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* progress * Update NEWS.md * Update NEWS.md
* in progress * progress
* updates * more updates * Update test-coverage.yaml * Update pull_request_template.md * updates * updates
* in progress * progress
* in progress * progress * progress
* in progress * Update tbl_summary.R
* moving indentation to its own table styling enttry * Update NEWS.md
* updates * updates
* Add tests for as_gt * Fix * Fix * Fix * Test * Test * Rearrange existing * Add tests for as_gt * Update footnotes test * Simplify interpreter test * Add footnotes test * Clean up * Add test for bold/italics * Add test for missing symbols * Add test for column merging * Simplify tests * Add test for missing values * Add tests for formatting functions --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* Initialize * Add tests * Test for formatting functions * Test for glance statistics * Test tbl_merge * Added explicit test for markdown syntax in headers
* raise attention * need at least this to get old tests working * how to use include for formula formation? * should work * as a fun exercise * add comments * nvm found the issue * DS review updates * move the tests and take in feedback * remove unncessary comments and return tbl_continuous back to original shape * use native pipe only --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* Add tests * Add test * Clean up
* there's preexisting add_global_p() tests? * add basic plot test * remove purrr dependencies * swap in tests for each argument * styler and fix errors * adopt feedback * accidentally pushed one * add geepack * new snap * make sure p-values match properly * avoid using example geepack uses * adopt feedback * forgot to push new snap --------- Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* making progress * progress * updates
* doc updates * snap updates * progress * progress
* mostly workflow updates * Update test-coverage.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This is a big one! Merging all the work towards version 2.0 to the main branch
Reviewer Checklist (if item does not apply, mark is as complete)
renv::install()
tbl_summary()
, was the same change implemented fortbl_svysummary()
?_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# gtsummary (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
codemetar::write_codemeta()
usethis::use_spell_check()
again