Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 to main branch #1778

Merged
merged 140 commits into from
Jun 29, 2024
Merged

v2.0 to main branch #1778

merged 140 commits into from
Jun 29, 2024

Conversation

ddsjoberg
Copy link
Owner

What changes are proposed in this pull request?
This is a big one! Merging all the work towards version 2.0 to the main branch


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed by running renv::install()
  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If an update was made to tbl_summary(), was the same change implemented for tbl_svysummary()?
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report()). Begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run codemetar::write_codemeta()
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

edelarua and others added 29 commits June 18, 2024 16:03
* Add tests for as_gt

* Fix

* Fix

* Fix

* Test

* Test

* Rearrange existing

* Add tests for as_gt

* Update footnotes test

* Simplify interpreter test

* Add footnotes test

* Clean up

* Add test for bold/italics

* Add test for missing symbols

* Add test for column merging

* Simplify tests

* Add test for missing values

* Add tests for formatting functions

---------

Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* Initialize

* Add tests

* Test for formatting functions

* Test for glance statistics

* Test tbl_merge

* Added explicit test for markdown syntax in headers
* progress

* Update NEWS.md

* Update _pkgdown.yml

* docs

* doc update

---------

Co-authored-by: Melkiades <davide.garolini@roche.com>
* progress

* Update NEWS.md

* Update _pkgdown.yml

* docs

* doc update

* progress

---------

Co-authored-by: Melkiades <davide.garolini@roche.com>
* Add tests for tbl_merge

* Add more tests

* Message test

* Update test-tbl_merge.R

---------

Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* Update inline_text.R

* in progress

* in progress

* progress

* Update _pkgdown.yml

* Update NEWS.md
* Initialize

* Reorder

* Wrong file

* Add tests

* Add snapshot

* Fix pkg check

* Update tbl_stack.md

* Add test for mismatched number of columns error

* fix

---------

Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* raise attention

* need at least this to get old tests working

* how to use include for formula formation?

* should work

* as a fun exercise

* add comments

* nvm found the issue

* DS review updates

* move the tests and take in feedback

* remove unncessary comments and return tbl_continuous back to original shape

* use native pipe only

---------

Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* init

* Add tests

* Updates after review

* Fix failing test
* progress

* in progress

* in progress

* Update DESCRIPTION

* progress
* progress

* progress

* Update _pkgdown.yml

* lil updates

* doc updates
* Create add_difference.tbl_svysummary.R

* progress

* Update _pkgdown.yml

* progress
* progress

* progress

* progress
* Add tests

* Add test

* Clean up
* there's preexisting add_global_p() tests?

* add basic plot test

* remove purrr dependencies

* swap in tests for each argument

* styler and fix errors

* adopt feedback

* accidentally pushed one

* add geepack

* new snap

* make sure p-values match properly

* avoid using example geepack uses

* adopt feedback

* forgot to push new snap

---------

Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
* making progress

* progress

* updates
* doc updates

* snap updates

* progress

* progress
* mostly workflow updates

* Update test-coverage.yaml
@ddsjoberg ddsjoberg merged commit 2596514 into main Jun 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants