Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appwindow: make sure tabs are not focusable #357

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

pesader
Copy link
Contributor

@pesader pesader commented Mar 7, 2023

Fix issue #87.

@amezin
Copy link
Member

amezin commented Mar 8, 2023

Looking at GNOME Terminal source code:

It overrides notebook widget's grab_focus virtual method, and redirects it to the active terminal widget. And does not touch can-focus property.

I wonder if there is any practical difference (usually for UI I try to replicate GNOME Terminal - unless there are reasons not to do so).

@amezin amezin merged commit ceb87bb into ddterm:master Mar 18, 2023
@pesader
Copy link
Contributor Author

pesader commented Mar 19, 2023

Hey, sorry for disappearing! Classes are already at full speed, so I haven't had the time to make the changes you requested.

I saw you merged my PR already though. Will we keep it that way, or do you still prefer to reimplement the fix using GNOME Terminal's method?

@amezin
Copy link
Member

amezin commented Mar 19, 2023

I saw you merged my PR already though. Will we keep it that way, or do you still prefer to reimplement the fix using GNOME Terminal's method?

Currently, most of the UI is loaded from Glade (.ui) files. Overriding grab_focus will be a non-trivial change (even though moving from .ui files to just code seems to be the right direction). So I decided to accept it in this form for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants