Remove handlebars dependency #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VTE doesn't actually handle icon title. Current file and directory are the only (possibly) useful values. However, they depend on VTE shell integration - which also doesn't work sometimes.
amezin
force-pushed
the
remove-handlebars
branch
3 times, most recently
from
882e660
to
28d27a7
Compare
But without handlebars templates
amezin
force-pushed
the
remove-handlebars
branch
from
28d27a7
to
02b4715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply use
window-titlefrom VTE as tab title.icon-titledoesn't actually workFile and directory URIs work only when VTE integration script was
sourcedShells already allow customization of
window-title, so don't over-engineer it.