Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPlacemarkProperties & IPlacemarkOptions are wrong #144

Closed
ddubrava opened this issue Oct 28, 2021 · 1 comment · Fixed by #148
Closed

IPlacemarkProperties & IPlacemarkOptions are wrong #144

ddubrava opened this issue Oct 28, 2021 · 1 comment · Fixed by #148
Assignees
@ddubrava
Labels
bug Something isn't working

Comments

@ddubrava
Copy link
Owner

🐞 Bug Report

✍️ Description

Remove [key: string]: any from IPlacemarkProperties.
IPlacemarkOptions should extend IHintOptionsWithHintPrefix.

🔬 Reproduction

image

🌎 Environment

"angular8-yandex-maps": "^12.2.0",
@ddubrava ddubrava added the bug Something isn't working label Oct 28, 2021
@ddubrava ddubrava self-assigned this Oct 28, 2021
@ddubrava
Copy link
Owner Author

IPlacemarkProperties & IPlacemarkOptions are complicated interfaces, IPlacemarkOptions interface has more than 50 properties, unfortunately, it's not safe to remove [key: string]: any

ddubrava added a commit that referenced this issue Oct 29, 2021
@ddubrava
feat(typings): add constructor in geometryEditor.Point class
1a5f8c6 
#144
ddubrava added a commit that referenced this issue Oct 29, 2021
@ddubrava
feat(typings): add constructor in layout.Image class
6a87773 
#144
ddubrava added a commit that referenced this issue Oct 29, 2021
@ddubrava
feat(typings): change extended interface for IPlacemarkOptions, make …
62f0854 
…Placemark.properties optional

closes #144
@ddubrava ddubrava mentioned this issue Oct 29, 2021
Merged
ddubrava added a commit that referenced this issue Oct 29, 2021
@ddubrava
fix(typings): replace layout.ImageWithContent with layout.IImageWithC…
3e4969d 
…ontentOptionsWithIconPrefix

#144
ddubrava added a commit that referenced this issue Oct 29, 2021
@ddubrava
feat(typings): improve IPlacemarkOptions, add constructor for geometr…
1397284 
…yEditor.Point and layout.Image (#148)

* feat(typings): add constructor in geometryEditor.Point class

#144

* feat(typings): add constructor in layout.Image class

#144

* feat(typings): change extended interface for IPlacemarkOptions, make Placemark.properties optional

closes #144

* fix(typings): replace layout.ImageWithContent with layout.IImageWithContentOptionsWithIconPrefix

#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddubrava ddubrava

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ddubrava