Fix warning for nested arrays with custom types

[KaanOzkan]

I've been encountering warnings such as:
@param tag has unknown parameter name: ] or @param tag has unknown parameter name: ,

I noticed that this only occurs with signatures that contain nested custom types such as T::Array[Custom[String]].

After debugging I noticed that the inner node Custom[String] is actually parsed as Custom[String]] within Yard parser.

So while converting T::Array[Custom[String]] node we correctly convert the outer T::Array and call convert with its children, the inner Custom[String]] node. Then we enter the else branch of the :aref case and return Custom[String]] which results in the warning.

I noticed that the parser returns an extra ] even for T::Array[String] signature. This case is not outputting a warning because we extract the relevant information here.

I wasn't 100% sure how to fix this so I'm open to suggestions. Currently I opted for a similar approach as the T::Array case. As you can see from the test cases for an input of T::Array[Custom[String]] we would output Array<Custom[String]> .

This could be wrong if we encountered "non array" signatures inside that else block. I'm curious if that is a possibility given we are in a :aref node

[codecov]

Codecov Report

Merging #11 (910c233) into master (7a1cb1d) will increase coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   92.44%   92.82%   +0.38%     
==========================================
  Files           2        2              
  Lines         225      237      +12     
==========================================
+ Hits          208      220      +12     
  Misses         17       17              

Impacted Files	Coverage Δ
spec/yard_sorbet/sig_handler_spec.rb	99.05% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1cb1d...910c233. Read the comment docs.

[dduugg]

Nice debugging story! Might be worth filing an issue in yard itself (but we're possibly using it in an supported way).