Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBB plugins in (Next|Own)Cloud not working #54

Closed
PhilippKilian opened this issue Nov 23, 2021 · 7 comments · Fixed by #55
Closed

BBB plugins in (Next|Own)Cloud not working #54

PhilippKilian opened this issue Nov 23, 2021 · 7 comments · Fixed by #55
Assignees
@PhilippKilian
Labels
bug Something isn't working
Milestone
2.2.2

Comments

@PhilippKilian
Copy link
Member

PhilippKilian commented Nov 23, 2021 •
edited by liske
Loading

NC/OC are encoding spaces in the query string by %20 rather than +. Although the BBB API suggests to use + BBB also accepts %20.

B3lb rejects those requests due how the checksum validation is implemented.
@PhilippKilian PhilippKilian self-assigned this Nov 23, 2021
@PhilippKilian PhilippKilian linked a pull request Nov 23, 2021 that will close this issue
change: use same checksum validation approach as BBB + bump dependencies #55
Merged
@liske liske changed the title Check for %20 or + as space escape character in request uri BBB plugins in (Next|Own)Cloud not working Nov 23, 2021
@liske liske added the bug Something isn't working label Nov 23, 2021
@liske
Copy link
Member

liske commented Nov 23, 2021 •
edited
Loading

Cc @kaystrobach @schmidtvolker

@liske liske added this to the 2.2.2 milestone Nov 23, 2021
@liske liske closed this as completed in #55 Nov 23, 2021
@kaystrobach
Copy link

ohh - thanks a lot - just asked my fellows at schullogin to send you the credentials. Will check right now.

@kaystrobach
Copy link

I think this patch is not deployed yet - right? I'm still getting the error. Will check later this week again.

@kaystrobach
Copy link

BTW. Does it make sense to patch the original BBB API Plugin of nextcloud? Maybe suggesting to use the standard PHP BBB API?

https://github.com/bigbluebutton/bigbluebutton-api-php

https://github.com/sualko/cloud_bbb/blob/af952b4cb0605d9445c2fbf709c05920f03e4762/composer.json#L13

@liske
Copy link
Member

liske commented Nov 23, 2021

I think this patch is not deployed yet - right? I'm still getting the error. Will check later this week again.

We are going to make a intermediate deployment for bbbconf.de this evening. We used another NC instance for debugging and validating the patch.

@liske
Copy link
Member

liske commented Nov 23, 2021

I think this patch is not deployed yet - right? I'm still getting the error. Will check later this week again.

We are going to make a intermediate deployment for bbbconf.de this evening. We used another NC instance for debugging and validating the patch.

The intermediate deployment is online!

@kaystrobach
Copy link

Woohoo works … more testing tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippKilian PhilippKilian

Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.2
Development

Successfully merging a pull request may close this issue.

change: use same checksum validation approach as BBB + bump dependencies DE-IBH/b3lb
3 participants
@liske @kaystrobach @PhilippKilian