Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folding actions: expand all /collapse all #34

Closed
de-jcup opened this issue Nov 5, 2018 · 5 comments
Closed

Folding actions: expand all /collapse all #34

de-jcup opened this issue Nov 5, 2018 · 5 comments
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@de-jcup
Copy link
Owner

de-jcup commented Nov 5, 2018

It's sometimes a little bit cumbersome to use folding feature : you have to select all parts wanted to be folded per mouse click.

When there are big documents and user wants a fast overview it maybe more convenient to have
context menu entries inside editor about

"Expand all folding"
"Collopse all foldings"

Maybe also an preference entry (disabled per default) "enable auto collapse foldings on editor startup"
should be introduced as well. The quick outline and the outline are showing always complete content,
so still accessible.

@PyvesB what do you think about this idea ?
@de-jcup de-jcup added the idea label Nov 5, 2018
@PyvesB
Copy link

PyvesB commented Nov 5, 2018

It's a good idea in my opinion, especially with the ability to tune the default behaviour in the preferences. There's also a nice feature in some Eclipse editors, "Toggle folding", which completely hides/unhides the folding buttons from the entire editor. 😉

@de-jcup
Copy link
Owner Author

de-jcup commented Nov 16, 2018 •
edited

Ruler context menu has got now the actions:
image

When folding is disabled, then expand/collapse all are disabled as well:
image

Preferences now in ruler context menu pointing to yaml editor preferences. Also changed text and behaviour so the global setup is now only for new opened editors, but can be changed in editors explicit.
image

@de-jcup de-jcup added this to the 1.1.0 milestone Nov 16, 2018
@de-jcup de-jcup added enhancement New feature or request and removed idea labels Nov 16, 2018
@PyvesB
Copy link

PyvesB commented Nov 20, 2018 •
edited

Nice, adding it to the ruler context menu seems like good user experience. 👍

By the way, the latest commit on the repository doesn't show the author properly.

@de-jcup
Copy link
Owner Author

de-jcup commented Nov 20, 2018

Thanks. I am using multiple devices for development. And the commit was on a machine completely reinstalled...

de-jcup added a commit that referenced this issue Nov 20, 2018
@de-jcup
Folding actions added to ruler context menu, closes #34
6375144 
- added folding actions: toggle, expand all, collapse all
- preferences in ruler context menu does now link to
  yaml editor pages + standard ones.
- changed behaviour: preferences now only the global, initial standard
  way of folding enabled or not. Editors can define this for their
  instance self respectively the user
@de-jcup
Copy link
Owner Author

de-jcup commented Nov 20, 2018 •
edited

did forced push, and changed author... so commit 6375144 replaces 494627f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@PyvesB @de-jcup