Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 11 handle default level problem #13

Merged
merged 3 commits into from Mar 17, 2023

Conversation

- added impl folder with parts for #12
- includes junit tests
- introduced shared folder for common parts
  (for later support of other sarif version and less
   copy waste...)
 - introduced additional parameters "--help" and "--clean"
   for `full-build.sh` script
 - currently one of the tests fails because of the default level
   problem
- this makes it possible to identify null objects as wanted inside
  SARIF specification
- even without Sarif210LogicSupport the behavior is as specified
  when somebody would not use the support class
@de-jcup de-jcup requested a review from winzj March 16, 2023 17:22
Copy link
Collaborator

@winzj winzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@de-jcup de-jcup merged commit 1e700ed into main Mar 17, 2023
1 check passed
@de-jcup de-jcup deleted the feature-11-handle-default-level-problem branch March 17, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants