Skip to content

Merge pull request #5 from hoijui/main #19

Merge pull request #5 from hoijui/main

Merge pull request #5 from hoijui/main #19

Triggered via push November 6, 2023 20:18
Status Success
Total duration 57s
Artifacts

rust.yml

on: push
Build and test
47s
Build and test
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
question mark operator is useless here: src/header.rs#L32
warning: question mark operator is useless here --> src/header.rs:32:2 | 32 | Ok(get_header_param(protected, unprotected, key).ok_or_else(|| Error::missing_header_param(key))?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `get_header_param(protected, unprotected, key).ok_or_else(|| Error::missing_header_param(key))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
the borrowed expression implements the required traits: src/compact.rs#L40
warning: the borrowed expression implements the required traits --> src/compact.rs:40:23 | 40 | base64.encode_string(&payload, &mut data); | ^^^^^^^^ help: change this to: `payload` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
question mark operator is useless here: src/header.rs#L32
warning: question mark operator is useless here --> src/header.rs:32:2 | 32 | Ok(get_header_param(protected, unprotected, key).ok_or_else(|| Error::missing_header_param(key))?) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `get_header_param(protected, unprotected, key).ok_or_else(|| Error::missing_header_param(key))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `#[warn(clippy::needless_question_mark)]` on by default
the borrowed expression implements the required traits: src/compact.rs#L40
warning: the borrowed expression implements the required traits --> src/compact.rs:40:23 | 40 | base64.encode_string(&payload, &mut data); | ^^^^^^^^ help: change this to: `payload` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this is an outer doc comment and does not apply to the parent module or crate: src/combine.rs#L1
warning: this is an outer doc comment and does not apply to the parent module or crate --> src/combine.rs:1:1 | 1 | ///! Combine multiple verifiers. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments = note: `#[warn(clippy::suspicious_doc_comments)]` on by default help: use an inner doc comment to document the parent module or crate | 1 | //! Combine multiple verifiers. |
this is an outer doc comment and does not apply to the parent module or crate: src/combine.rs#L1
warning: this is an outer doc comment and does not apply to the parent module or crate --> src/combine.rs:1:1 | 1 | ///! Combine multiple verifiers. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments = note: `#[warn(clippy::suspicious_doc_comments)]` on by default help: use an inner doc comment to document the parent module or crate | 1 | //! Combine multiple verifiers. |
Build and test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/