Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script wrongly detects some domains #1

Closed
hawkeye116477 opened this issue Feb 25, 2019 · 1 comment
Closed

Script wrongly detects some domains #1

hawkeye116477 opened this issue Feb 25, 2019 · 1 comment
Assignees
@funilrys
Labels
bug Something isn't working

Comments

@hawkeye116477
Copy link

hawkeye116477 commented Feb 25, 2019 •
edited

Welcome! I'd like to inform you that KAD has new owners => https://github.com/PolishFiltersTeam.
I'd like to inform you also that your script wrongly detects some domains, for example pogotowie-komputerowe-warszawa.com.pl is still registered. I assume that's probably, cuz it doesn't correctly extracts expiration date for that domains.
Anyway, now we have also our own script for detecting expired domains, so if you want, you can remove that repo 😄.
@hawkeye116477 hawkeye116477 changed the title KAD has new owners Script wrongly detects some domains Feb 25, 2019
@funilrys
Copy link
Member

Hi @hawkeye116477, Did you reported it to Steven's hosts repository ?

Thanks for reporting. Actually PyFunceble do more than "detecting expired domains" 😉

Will look into that more precisely.

Cheers,
Nissar

@funilrys funilrys added the bug Something isn't working label Feb 25, 2019
@funilrys funilrys self-assigned this Feb 25, 2019
@funilrys funilrys mentioned this issue Feb 25, 2019
Closed
funilrys added a commit to PyFunceble/rst-docs that referenced this issue Apr 27, 2024
@funilrys
Review of the way we catch if a domain is a subdomain.
7d69249 
This patch fix #22.

Indeed, some domains registered into the PSL were wrongly marked as domain instead of subdomain.

Also:
  * Introduction of @hawkeye116477 into the list of contributors.

Contributors:
  * @hawkeye116477

Side Note:
  * This patch also fix dead-hosts/KADhosts_git_azet12#1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@funilrys funilrys

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funilrys @hawkeye116477