Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help] Please update the docs as now we can install dotdrop with Homebrew 馃コ #345

Closed
curoky opened this issue May 17, 2022 · 6 comments
Labels

Comments

@curoky
Copy link

curoky commented May 17, 2022

What I am trying to achieve

Install dotdrop with Homebrew, it looks like

brew install dotdrop

What I have tried so far

I create a PR(Homebrew/homebrew-core#101255) on https://github.com/Homebrew/homebrew-core and it has been merged into the master.

So the only thing left is to update docs and README. 馃樇

@curoky curoky added the help label May 17, 2022
deadc0de6 added a commit that referenced this issue May 17, 2022
@deadc0de6
Copy link
Owner

Wow that's very nice!! Thanks a lot for this 馃憤

@deadc0de6
Copy link
Owner

@deadc0de6
Copy link
Owner

BTW I'm wondering if we should/can put the dependencies listed here: https://dotdrop.readthedocs.io/en/latest/installation/#dependencies

@curoky
Copy link
Author

curoky commented May 21, 2022

Of course, we can!

It seems that coreutils is only required when use the entry point script dotdrop.sh, so I just added libmagic.

Homebrew bundles dotdrop via pip venv, so it doesn't need dotdrop.sh ?

@deadc0de6
Copy link
Owner

Awesome, thanks again!
Absolutely, libmagic is enough, no need for coreutils or dotdrop.sh (which is only needed when using dotdrop as a submodule).

@curoky
Copy link
Author

curoky commented May 22, 2022

Done, Homebrew/homebrew-core#102043 already merged.

Very useful software, glad to have the opportunity to make some trivial contributions. 馃槉

@curoky curoky closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants