-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Negative (non-ignore) patterns refuse to match anything #388
Comments
Thanks for reporting this, I was able to reproduce the bug and will investigate! |
Hey, I'm glad to see you're still working on this, and I just wanted to mention that I appreciate it. Is there anything I could help with, like testing or small tasks - I don't have much free time, but I'm pretty well versed in Python. |
Hey, sure no problem. I must admit it was more complex than I expected and while searching to solve your issue, I found bugs in negative ignore spanning across other actions (install, compare, update, import). |
@niraami I think I have something in the bug#388 branch. Could you test your use case using that branch? Here is a little explanation on how to do the testing: https://dotdrop.readthedocs.io/en/latest/howto/test-latest-dotdrop/ |
Yep, I'll test it as soon as I can. |
@niraami this was merged and is then available on the master branch. Thanks |
Dotdrop version: v1.13.0-1
Using dotdrop: dotdrop from AUR
Describe the bug
When using ignore patterns, I can't get the inverse ignore pattern working. Every time I add ignore for '*', all subsequent non-ignore patterns don't get applied.
Steps to Reproduce
Add the following kind of ignore pattern to a dotfile (my example is a Blender config directory):
Run
dotdrop update --dry
, you'll see the folders ignored (twice) anyways:Expected behavior
Files that match the negative ignore pattern should not get ignored.
Additional information
I've tried all sorts of other patterns, and different folders, with and/or without globs in the patterns, single and double quotes, but could not get it to work.
Dotdrop's execution with the debug logs (
--verbose
) with the above config:Relevant documentation is here.
The text was updated successfully, but these errors were encountered: