Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 #30

Merged
merged 73 commits into from
Sep 17, 2016
Merged

Version 3 #30

merged 73 commits into from
Sep 17, 2016

Conversation

deadtrickster
Copy link
Owner

@deadtrickster deadtrickster commented Sep 3, 2016

Breaking Changes:

  • invalid_metric_arity tuple changed. Added metric real arity to invalid_metric_arity error tuple;
  • fix histogram,summary:observe_duration arguments order (Registry now goes first);
  • changed collect_mf/3,2 args order;
  • default collectors env key changed to 'collectors';
  • default instrumenters env key changed to 'instrumenters';
  • prometheus_buckets removed deprecations
    generate_linear/3,
    generate_exponential/3;
  • prometheus_histogram: removed deprecated bounds config support;
  • tweak histogram_invalid_buckets error tuple. It always has three elements now;
  • prometheus_histogram:*_buckets functions are private.

Deprecations:

  • deprecate prometheus_collector:register/deregister;
  • deprecate metric:new,declare/2.

What's new:

  • added metric real arity to invalid_metric_arity error tuple;
  • :value returns undefined for unknown label set;
  • :set,reset,value raise unknown_metric|invalid_metric_arity;
  • :observe,observe_duration,track_inprogress raise unknown_metric|invalid_metric_arity;
  • :d functions raise unknown_metric|invalid_metric_arity before gen_server:cast;
  • :new,declare/1 accept registry key;
  • prometheus_registry:register_collector(s),deregister_collector/1;
  • prometheus_registry:collector_registeredp/1;
  • gauge:set accepts undefined which is rendered as NaN;
  • new error messages;
  • track_inprogress/observe_duration raise invalid_value error when Fun is not a function;
  • gauge (d)inc/(d)dec;
  • gauge:set_duration;
  • :remove - can remove series for a given label set;
  • untyped metric support;
  • erlang_vm_system_info_collector;
  • new time measurement system New time measurement system #32;
  • gen_server:call support with custom timeout Make call/cast configurable for dinc/dobserve. #33.

Other

  • rebar3 updated;
  • coveralls integration;
  • tests, refactors;
  • docs.

add metric real arity to invalid_metric_arity error tuple
test counter:inc,reset,value throw unknown_metric|invalid_metric_arity
counter:value should return undefined if labels combination is unknown

gauge:value should return undefined if labels combination is unknown
gauge:set,reset,value throw unknown_metric|invalid_metric_arity
gauge:set_to_current_time,track_inprogress should throw unknown_metric|invalid_metric_arity

[b] fix histogram,summary:observe_duration arguments order (Registry should go firts)

summary:observe,observe_duration,reest,value should throw unknown_metric|invalid_metric_arity
summary:value should return undefined if labels combination doesn't exist

histogram:observe,observe_duration,reset,value,buckets should throw unknown_metric|invalid_metric_arity
histogram:value should return undefined if labels combination doesn't exist

dobserve/dinc should throw unknown_metric/invalid_metric_arity before casting
generate_linear/3,
generate_exponential/3
[e] Support for registry spec key added.
closes #27.
Properly use @deprecated tag
Add @Private tags
Break prometheus_metric:value type to subtypes
@coveralls
Copy link

coveralls commented Sep 14, 2016

Coverage Status

Changes Unknown when pulling ce8268f on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling 1597133 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling fda1987 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling fdb8e98 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling 90e40eb on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling 3d80851 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling 789edf2 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling d0300e6 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Changes Unknown when pulling c09c3d9 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Changes Unknown when pulling b8fe341 on version-3 into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2bc3f09 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Changes Unknown when pulling c7cd6e9 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Changes Unknown when pulling 8be4493 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Changes Unknown when pulling 8be4493 on version-3 into * on master*.

@coveralls
Copy link

coveralls commented Sep 16, 2016

Coverage Status

Changes Unknown when pulling 79eb8bd on version-3 into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants