Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: public "getCroppedBitmap" method #25

Merged
merged 1 commit into from May 1, 2023

Conversation

monsieurtanuki
Copy link
Contributor

There are cases when we need to use that crop method beyond the use of an instance of a CropController.

There are cases when we need to use that crop method beyond the user of an instance of a CropController.
@deakjahn
Copy link
Owner

deakjahn commented May 1, 2023

Well, if you think... :-)

@deakjahn deakjahn merged commit 78547f4 into deakjahn:master May 1, 2023
@monsieurtanuki
Copy link
Contributor Author

Well, if you think... :-)

Hi @deakjahn! Oh it's even a fact: we need it in our app.
The use case is: we crop an image the size of the screen in real time (with the CropController), which is good enough and fast enough in a first approach, but processing the full image takes too long and we do it later in a background task. And in that background task we don't have the CropController anymore, just the full file and the crop parameters.

@deakjahn
Copy link
Owner

deakjahn commented May 1, 2023

You could've copied the code but you took the easy way out, I see. :-)

@monsieurtanuki
Copy link
Contributor Author

I did copy the code, temporarily, until you release 1.0.6 ;)
I assumed that making the method public would make sense and couldn't jeopardy your package's integrity.

@deakjahn
Copy link
Owner

deakjahn commented May 1, 2023

Nudge, nudge, wink, wink. I know... :-)

deakjahn added a commit that referenced this pull request May 1, 2023
@monsieurtanuki
Copy link
Contributor Author

Nudge, nudge, wink, wink. I know... :-)

Thank you for the 1.0.6, and thank you for the quote!
Slightly related: https://www.youtube.com/watch?v=ifLqzLEB3E0

@deakjahn
Copy link
Owner

deakjahn commented May 1, 2023

Only slightly, but good -- in a sad way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants