Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't dispose controllers passed from outside #27

Merged
merged 1 commit into from Jun 9, 2023
Merged

Don't dispose controllers passed from outside #27

merged 1 commit into from Jun 9, 2023

Conversation

Hannnes1
Copy link
Contributor

@Hannnes1 Hannnes1 commented Jun 9, 2023

This solves an issue where the CropController is disposed even if it is owned by another object.

Fixes #15

@deakjahn deakjahn merged commit 944e258 into deakjahn:master Jun 9, 2023
deakjahn added a commit that referenced this pull request Jun 9, 2023
@deakjahn
Implement #27
911cee3
@Hannnes1 Hannnes1 deleted the dispose-fix branch June 9, 2023 12:12
@deakjahn
Copy link
Owner

Thanks.

@Hannnes1
Copy link
Contributor Author

No problem. Glad I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Hannnes1 @deakjahn